-
Notifications
You must be signed in to change notification settings - Fork 1
Description
When the user clicks the reset button it clears the entire sync storage and does not just reset the options/settings. The issue is this line which calls storage.sync.clear():
AutomaticSettings/internal/LoadAndSave.js
Lines 321 to 322 in 4e6c058
| // finally reset options | |
| browser.storage.sync.clear().then(() => loadAllOptions().then( |
This is problematic for add-ons that have multiple options pages (#13), as it will reset all of them. It is also an issue when the sync storage is used for other stuff, such as by the RandomTips library, which causes the user to see all of the tips again. The library should instead call storage.sync.remove() with the specific keys of the items to remove.
This currently affects my "FileLink provider for Send" add-on, which can have multiple account management pages, plus a regular options page. For example, if the user resets one of the account management pages, it will also reset all of the others and the options page. 😱