Skip to content

Reset button clears entire Sync storage, not just the settings #24

@tdulcet

Description

@tdulcet

When the user clicks the reset button it clears the entire sync storage and does not just reset the options/settings. The issue is this line which calls storage.sync.clear():

// finally reset options
browser.storage.sync.clear().then(() => loadAllOptions().then(

This is problematic for add-ons that have multiple options pages (#13), as it will reset all of them. It is also an issue when the sync storage is used for other stuff, such as by the RandomTips library, which causes the user to see all of the tips again. The library should instead call storage.sync.remove() with the specific keys of the items to remove.

This currently affects my "FileLink provider for Send" add-on, which can have multiple account management pages, plus a regular options page. For example, if the user resets one of the account management pages, it will also reset all of the others and the options page. 😱

Also see #5 and #26.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions