Erroneous "object is not frozen" warnings

[tdulcet]

Originally mentioned by @rugk in #6 (comment). Users will get many of these erroneous warnings on extensions with several option groups, like the Awesome Emoji Picker, which is confusing for developers creating PRs (#6 (comment)).

This issue is the unfreezeObject() function:

AddonSettings/AddonSettings.js

Lines 33 to 47 in 7855b9d

	function unfreezeObject(value) {
	// always shallow-copy
	if (Array.isArray(value)) {
	value = value.slice();
	} else if ((isPlainObject(value))) {
	value = Object.assign({}, value);
	} else {
	// return primitive value or similar ones
	return value;
	}
	// but warn if object was not even frozen, so deev can fix the default settings
	if (!Object.isFrozen(value)) {
	console.warn("The following defined default value of type", typeof value, "is not frozen. It is recommend that all default options are frozen.", value);
	}

It checks if the objects are not frozen after doing the shallow-copy. They will of course never be frozen after the shallow-copy, which is why this warning always outputs every time the function is called with an object, regardless of whether the object was initially frozen or not...

[rugk]

Uuups… thanks a lot!
Indeed seems to be a bug.

Just switching the order of the checks should work, should not it?

If so, you're free to do a PR, so you can get the credit as the commit message author and thanks again for finding and spotting that! 😃

[tdulcet]

Uuups… thanks a lot!

No problem! I had been meaning to create this for over a year...

Just switching the order of the checks should work, should not it?

Yes, although it may be better to just assign the shallow-copy to a new variable, to avoid the resulting type coercion with non-object arguments.

[rugk]

Well… the last thing should be no problem, as we use ES2015 or later.
But anyway, also code-style wise it may make sense to rename the variable, so feel free to do so.