Bug in ReferencedObject::__init__

[manulera]

Hello, I think there is an error in ReferencedObject::__init__. I found it like this:

import sbol2

participation = sbol2.Participation('p', participant='p1')
print(sbol2.ReferencedObject(participation, 'aa','bb', '1', '1', [], 'aaa'))
print(participation.participant) #prints none

I think I found the error, posting a PR soon.

[jakebeal]

The patch committed was not working correctly. I am going undoing it and we can try again with a new patch that the GitHub actions actually run against

[manulera]

This is fixed now. This should be fixed with #436

I don't understand what is the use-case for the if statement. When is self._sbol_owner None, and why not assign the property in that case and add an empty list instead?

I noticed that there is other similar if statements in the file, maybe it would be good to review them.

[bbartley]

Ran into this bug myself today. As a consequence of this, classes such as MapsTo and FunctionalComponent that have required properties of this type cannot be properly initialized by constructor:

import sbol2
import sbol2.mapsto

# FunctionalComponent(uri=rdflib.term.URIRef('example'), definition='', access='http://sbols.org/v2#public', direction='http://sbols.org/v2#none', version='1')
fc = sbol2.FunctionalComponent('fc', 'http://cd', sbol2.SBOL_ACCESS_PUBLIC, sbol2.SBOL_DIRECTION_IN)

#MapsTo(type_uri='http://sbols.org/v2#MapsTo', uri=rdflib.term.URIRef('example'), local='', remote='', refinement='http://sbols.org/v2#verifyIdentical', version='1')
mt = sbol2.mapsto.MapsTo('mt', 'http://cd', 'http://cd')

print(fc.definition)
print(mt.local)
print(mt.remote)

Results in:

None
None
None

The workaround for now is to assign the property value after construction.