[3.0]: Unknown named parameter $timestamp (again)

[Oldiesmann]

Basic Information

Still getting an "Unknown named parameter $timestamp" error with caching enabled.

Steps to reproduce

1. Enable caching
2. Go to the board index or other area outside the admin center and leave the tab open on that page for a while
3. Come back to the tab and go to the board index

Expected result

Board index loads like normal

Actual result

"Unknown named parameter $timestamp"

Version/Git revision

d81420f

Database Engine

All

Database Version

No response

PHP Version

8.4.14

Logs

Unknown named parameter $timestamp
/.../Sources/Cache/CacheApi.php
Line 513

Backtrace:


    #0: SMF\Actions\BoardIndex->execute()
    Called from /.../Sources/Forum.php on line 470
    #1: SMF\Forum->execute()
    Called from /.../index.php on line 149

Additional Information

I'm using Level 1 caching with APCu on both boards where this occurred, but I would assume it happens with any accelerator.

[jdarwood007]

Do you have any mods installed that may be calling cache_quick_get?

[Oldiesmann]

No mods at all. This is the installation where I've been testing my reactions stuff but that doesn't call cache_quick_get at all and wouldn't be loading reaction info on the boardindex anyway

[jdarwood007]

I can't reproduce, but I think I found it.

Lets try: Sources/Action/Calendar.php

				'callback' => self::class . '::cacheIsOutdated',
				'args' => [
					'date' => Time::strftime('%Y%m%d', time()),
					'timestamp' => time(),
				],

Change timestamp to time

[Oldiesmann]

That appears to have fixed it.

[Oldiesmann]

Unfortunately that didn't fix it after all (not sure why the error went away after that change initially, but it's back). However, looking at the backtrace, I believe I have found the issue. It appears to be an issue with the cache_getLatestPostCallback method in Sources/Actions/BoardIndex.php, which is a callback function for CacheApi::QuickGet, the method throwing the error:

SMF/Sources/Actions/BoardIndex.php

Lines 280 to 286 in 5dfb9e3

	public static function cache_getLastPostCallback(array &$cache_block, array &$params): void
	{
	foreach ($cache_block['data'] as $k => $post) {
	$cache_block['data'][$k]['time'] = Time::create('@' . $post['raw_timestamp'])->format();
	$cache_block['data'][$k]['timestamp'] = $post['raw_timestamp'];
	}
	}

If I comment out the second line in that foreach loop, the error goes away.