[BUG] Error-Cannot convert argument to a ByteString

[gridstan89]

Problem (one or two sentences)

Error working with indexer
Cannot covert argument to a ByteString because the character at index 8 has a value of 1040 which is greater than 255

Context (who is affected and when)

Error appears after configuring settings and pressing save button

Reproduction steps

MacOS Sonoma 14.8
VS Code 1.99.3
Roo Code version 3.43.0

Expected result

Codebase indexing works properly

Actual result

Codebase indexing reproduces errors

Variations tried (optional)

No response

App Version

Roo Code version 3.43.0

API Provider (optional)

OpenAI Compatible

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote]

I've analyzed this issue and here's my proposed implementation plan:

Root Cause Analysis:

The error "Cannot convert argument to a ByteString because the character at index 8 has a value of 1040 which is greater than 255" indicates that non-ASCII characters (character 1040 is Cyrillic capital "А") are present in the API key or base URL configuration for the codebase indexer. HTTP headers only support Latin-1 characters (values 0-255), so when the OpenAI SDK or fetch API tries to set headers containing such characters, it throws this error.

The codebase already has handling for ByteString errors in the main API provider error handler (src/api/providers/utils/error-handler.ts), but the embedder validation flow in src/services/code-index/shared/validation-helpers.ts lacks this specific error handling, causing the raw technical error message to be displayed to users.

Proposed Solution:

1. Update handleValidationError in src/services/code-index/shared/validation-helpers.ts:

   • Add specific handling for ByteString conversion errors (check for "Cannot convert argument to a ByteString" in the error message)
   • Return a user-friendly localized message indicating that the API key or base URL contains invalid characters

2. Add i18n translation key for this error case in the embeddings namespace (e.g., embeddings:validation.invalidCharactersInConfig)

3. Add test coverage for this scenario in the validation-helpers test file

This approach will:

• Provide a clear, actionable error message to users
• Be consistent with the existing ByteString error handling in other parts of the codebase
• Help users identify that they need to check their API key and base URL for special characters (often caused by copy-paste issues or keyboard layout switching)

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.

[daniel-lxs]

@roomote proceed with the implementation.

[roomote]

Thanks for the approval! I'll proceed with implementing the ByteString error handling for the embedder validation flow. I'll open a draft PR shortly to share progress.

[roomote]

Opened draft PR #10974 with my attempt at addressing this ByteString error. The fix adds handling in the embedder validation flow to catch the ByteString conversion error and return a user-friendly message. Feedback welcome!