From 9473f5eaf4255ab30cc61e78bd92fdfd7ced4a21 Mon Sep 17 00:00:00 2001 From: Jackson Burns Date: Sun, 9 Jun 2024 10:04:33 -0400 Subject: [PATCH 1/2] Revert "temporarily remove `minimal_surface` regression test" This reverts commit 4889ca09f6886ca3b4db73f508ffcc24df29c601. --- .github/workflows/CI.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 7b5a39c162..b9b8ed39ed 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -167,7 +167,7 @@ jobs: id: regression-execution timeout-minutes: 60 run: | - for regr_test in aromatics liquid_oxidation nitrogen oxidation sulfur superminimal RMS_constantVIdealGasReactor_superminimal RMS_CSTR_liquid_oxidation RMS_liquidSurface_ch4o2cat fragment RMS_constantVIdealGasReactor_fragment; + for regr_test in aromatics liquid_oxidation nitrogen oxidation sulfur superminimal RMS_constantVIdealGasReactor_superminimal RMS_CSTR_liquid_oxidation RMS_liquidSurface_ch4o2cat fragment RMS_constantVIdealGasReactor_fragment minimal_surface; do if python-jl rmg.py test/regression/"$regr_test"/input.py; then echo "$regr_test" "Executed Successfully" @@ -243,7 +243,7 @@ jobs: run: | exec 2> >(tee -a regression.stderr >&2) 1> >(tee -a regression.stdout) mkdir -p "test/regression-diff" - for regr_test in aromatics liquid_oxidation nitrogen oxidation sulfur superminimal RMS_constantVIdealGasReactor_superminimal RMS_CSTR_liquid_oxidation fragment RMS_constantVIdealGasReactor_fragment; + for regr_test in aromatics liquid_oxidation nitrogen oxidation sulfur superminimal RMS_constantVIdealGasReactor_superminimal RMS_CSTR_liquid_oxidation fragment RMS_constantVIdealGasReactor_fragment minimal_surface; do echo "" echo "### Regression test $regr_test:" From 721be6933ea87fc861515ecff9dc960597cffd7d Mon Sep 17 00:00:00 2001 From: Jackson Burns <33505528+JacksonBurns@users.noreply.github.com> Date: Mon, 10 Jun 2024 10:07:45 -0400 Subject: [PATCH 2/2] _severely_ limit mechanism size to not crash github actions runners OOM github actions runners have relatively limited memory the mechanism size that would result from this would crash the runners with OOM errors when attempting to run cantera simulations this fixes the issue by limiting the size of the mechanism. this does remove the scientific validity of the test, but at least covers some basic functionality and correctness checks --- test/regression/minimal_surface/input.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/regression/minimal_surface/input.py b/test/regression/minimal_surface/input.py index ddfea2dd87..9054a32827 100644 --- a/test/regression/minimal_surface/input.py +++ b/test/regression/minimal_surface/input.py @@ -104,7 +104,8 @@ toleranceKeepInEdge=0.0, toleranceMoveToCore=1e-1, toleranceInterruptSimulation=0.1, - maximumEdgeSpecies=100000, + maximumEdgeSpecies=100, + maxNumSpecies=10, ) options( units='si',