Skip to content

Commit 77264e7

Browse files
🩹 [Patch]: Update workflow configurations to improve secret management and linter summary handling
1 parent 61232e3 commit 77264e7

File tree

5 files changed

+27
-5
lines changed

5 files changed

+27
-5
lines changed

‎.github/workflows/Auto-Release.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Auto-Release
33
run-name: "Auto-Release - [${{ github.event.pull_request.title }} #${{ github.event.pull_request.number }}] by @${{ github.actor }}"
44

55
on:
6-
pull_request_target:
6+
pull_request:
77
branches:
88
- main
99
types:
@@ -27,6 +27,8 @@ jobs:
2727
steps:
2828
- name: Checkout Code
2929
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
30+
with:
31+
persist-credentials: false
3032

3133
- name: Auto-Release
3234
uses: PSModule/Auto-Release@eabd533035e2cb9822160f26f2eda584bd012356 # v1.9.5

‎.github/workflows/Build-Docs.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,13 @@ jobs:
9595
- name: Post super-linter summary
9696
if: failure() || fromJson(inputs.Settings).Build.Docs.ShowSummaryOnSuccess == true
9797
shell: pwsh
98+
env:
99+
SUPER_LINTER_OUTCOME: ${{ steps.super-linter.outcome }}
98100
run: |
99101
$summaryPath = Join-Path $env:GITHUB_WORKSPACE 'super-linter-output' 'super-linter-summary.md'
100102
Get-Content $summaryPath | Out-File -FilePath $env:GITHUB_STEP_SUMMARY -Encoding utf8
101103
102-
$failed = '${{ steps.super-linter.outcome }}' -eq 'failure'
104+
$failed = $env:SUPER_LINTER_OUTCOME -eq 'failure'
103105
if ($failed) {
104106
Write-Host "::error::Super-linter found issues. Please review the summary above."
105107
exit 1

‎.github/workflows/Lint-Repository.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,13 @@ jobs:
5959
- name: Post super-linter summary
6060
if: failure() || fromJson(env.Settings).Linter.ShowSummaryOnSuccess == true
6161
shell: pwsh
62+
env:
63+
SUPER_LINTER_OUTCOME: ${{ steps.super-linter.outcome }}
6264
run: |
6365
$summaryPath = Join-Path $env:GITHUB_WORKSPACE 'super-linter-output' 'super-linter-summary.md'
6466
Get-Content $summaryPath | Out-File -FilePath $env:GITHUB_STEP_SUMMARY -Encoding utf8
6567
66-
$failed = '${{ steps.super-linter.outcome }}' -eq 'failure'
68+
$failed = $env:SUPER_LINTER_OUTCOME -eq 'failure'
6769
if ($failed) {
6870
Write-Host "::error::Super-linter found issues. Please review the summary above."
6971
exit 1

‎.github/workflows/Workflow-Test-Default.yml‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,14 @@ permissions:
2222
jobs:
2323
WorkflowTestDefault:
2424
uses: ./.github/workflows/workflow.yml
25-
secrets: inherit
25+
secrets:
26+
APIKey: ${{ secrets.APIKey }}
27+
TEST_APP_ENT_CLIENT_ID: ${{ secrets.TEST_APP_ENT_CLIENT_ID }}
28+
TEST_APP_ENT_PRIVATE_KEY: ${{ secrets.TEST_APP_ENT_PRIVATE_KEY }}
29+
TEST_APP_ORG_CLIENT_ID: ${{ secrets.TEST_APP_ORG_CLIENT_ID }}
30+
TEST_APP_ORG_PRIVATE_KEY: ${{ secrets.TEST_APP_ORG_PRIVATE_KEY }}
31+
TEST_USER_ORG_FG_PAT: ${{ secrets.TEST_USER_ORG_FG_PAT }}
32+
TEST_USER_USER_FG_PAT: ${{ secrets.TEST_USER_USER_FG_PAT }}
33+
TEST_USER_PAT: ${{ secrets.TEST_USER_PAT }}
2634
with:
2735
WorkingDirectory: tests/srcTestRepo

‎.github/workflows/Workflow-Test-WithManifest.yml‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,14 @@ permissions:
2222
jobs:
2323
WorkflowTestWithManifest:
2424
uses: ./.github/workflows/workflow.yml
25-
secrets: inherit
25+
secrets:
26+
APIKey: ${{ secrets.APIKey }}
27+
TEST_APP_ENT_CLIENT_ID: ${{ secrets.TEST_APP_ENT_CLIENT_ID }}
28+
TEST_APP_ENT_PRIVATE_KEY: ${{ secrets.TEST_APP_ENT_PRIVATE_KEY }}
29+
TEST_APP_ORG_CLIENT_ID: ${{ secrets.TEST_APP_ORG_CLIENT_ID }}
30+
TEST_APP_ORG_PRIVATE_KEY: ${{ secrets.TEST_APP_ORG_PRIVATE_KEY }}
31+
TEST_USER_ORG_FG_PAT: ${{ secrets.TEST_USER_ORG_FG_PAT }}
32+
TEST_USER_USER_FG_PAT: ${{ secrets.TEST_USER_USER_FG_PAT }}
33+
TEST_USER_PAT: ${{ secrets.TEST_USER_PAT }}
2634
with:
2735
WorkingDirectory: tests/srcWithManifestTestRepo

0 commit comments

Comments
 (0)