From ea4ba5fd2e4655f6ef33d8c133de954ee90f233d Mon Sep 17 00:00:00 2001 From: James Bruten <109733895+james-bruten-mo@users.noreply.github.com> Date: Mon, 12 Jan 2026 15:04:02 +0000 Subject: [PATCH 1/2] add project workflow --- .github/pull_request_template.md | 69 ++++++++++++++----- .github/workflows/track-review-project.yaml | 12 ++++ .../workflows/trigger-project-workflow.yaml | 12 ++++ 3 files changed, 77 insertions(+), 16 deletions(-) create mode 100644 .github/workflows/track-review-project.yaml create mode 100644 .github/workflows/trigger-project-workflow.yaml diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 15fbc1cc..7345962e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,32 +1,69 @@ -# Description +# PR Summary -## Summary +Sci/Tech Reviewer: +Code Reviewer: -_Briefly describe the feature being introduced._ + -## Changes + -_List the major changes made in this pull request._ + -## Dependency + -_List dependent changes. Can use build-group logic here._ +## Code Quality Checklist -## Impact +- [ ] I have performed a self-review of my own code +- [ ] My code follows the project's [style guidelines](https://metoffice.github.io/lfric_core/how_to_contribute/index.html#how-to-contribute-index) +- [ ] Comments have been included that aid understanding and enhance the readability of the code +- [ ] My changes generate no new warnings +- [ ] All automated checks in the CI pipeline have completed successfully -_Discuss any potential impacts this feature may have on existing functionalities._ +## Testing -## Issues addressed +- [ ] This change has been tested appropriately (please describe) -Resolves +## Security Considerations -_List issue(s) related to this PR._ +- [ ] I have reviewed my changes for potential security issues +- [ ] Sensitive data is properly handled (if applicable) +- [ ] Authentication and authorisation are properly implemented (if applicable) -## Coordinated merge +## AI Assistance and Attribution -_Specify any coordinated merges here._ +- [ ] Some of the content of this change has been produced with the assistance of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the [Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html) (including attribution labels) + -## Checklist +# Sci/Tech Review + + + + +- [ ] I understand this area of code and the changes being added +- [ ] The proposed changes correspond to the pull request description +- [ ] Documentation is sufficient (do documentation papers need updating) +- [ ] Sufficient testing has been completed + +(_Please alert the code reviewer via a tag when you have approved the SR_) + +# Code Review + + + +- [ ] All dependencies have been resolved +- [ ] Related Issues have been properly linked and addressed +- [ ] Code quality standards have been met +- [ ] Tests are adequate and have passed +- [ ] Security considerations have been addressed +- [ ] Performance impact is acceptable -- [ ] I have performed a self-review of my own changes diff --git a/.github/workflows/track-review-project.yaml b/.github/workflows/track-review-project.yaml new file mode 100644 index 00000000..c636b862 --- /dev/null +++ b/.github/workflows/track-review-project.yaml @@ -0,0 +1,12 @@ +name: Track Review Project + +on: + workflow_run: + workflows: [Trigger Review Project] + types: + - completed + +jobs: + track_review_project: + uses: MetOffice/growss/.github/workflows/track-review-project.yaml@main + secrets: inherit diff --git a/.github/workflows/trigger-project-workflow.yaml b/.github/workflows/trigger-project-workflow.yaml new file mode 100644 index 00000000..c0215bbd --- /dev/null +++ b/.github/workflows/trigger-project-workflow.yaml @@ -0,0 +1,12 @@ +name: Trigger Review Project + +on: + pull_request_target: + types: ["opened", "synchronize", "reopened", "edited", "review_requested", "review_request_removed"] + pull_request_review: + pull_request_review_comment: + +jobs: + trigger_project_workflow: + uses: MetOffice/growss/.github/workflows/trigger-project-workflow.yaml@main + secrets: inherit From 4a84d5aaf0b851c437d25f5a4cdd90b8bf931471 Mon Sep 17 00:00:00 2001 From: James Bruten <109733895+james-bruten-mo@users.noreply.github.com> Date: Tue, 13 Jan 2026 08:25:18 +0000 Subject: [PATCH 2/2] add permissions --- .github/workflows/track-review-project.yaml | 5 +++++ .github/workflows/trigger-project-workflow.yaml | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/.github/workflows/track-review-project.yaml b/.github/workflows/track-review-project.yaml index c636b862..639477cd 100644 --- a/.github/workflows/track-review-project.yaml +++ b/.github/workflows/track-review-project.yaml @@ -6,6 +6,11 @@ on: types: - completed +permissions: + actions: read + contents: read + pull-requests: write + jobs: track_review_project: uses: MetOffice/growss/.github/workflows/track-review-project.yaml@main diff --git a/.github/workflows/trigger-project-workflow.yaml b/.github/workflows/trigger-project-workflow.yaml index c0215bbd..4d0a8f6e 100644 --- a/.github/workflows/trigger-project-workflow.yaml +++ b/.github/workflows/trigger-project-workflow.yaml @@ -6,6 +6,11 @@ on: pull_request_review: pull_request_review_comment: +permissions: + actions: read + contents: read + pull-requests: write + jobs: trigger_project_workflow: uses: MetOffice/growss/.github/workflows/trigger-project-workflow.yaml@main