Mapserver source: msLoadMap takes a new parameter

[mamaar]

Since this commit: MapServer/MapServer@f478a37
MapServer seems to take a new parameter for config. The MapServer source in Mapcache has not been updated to reflect this change:

• mapcache/lib/source_mapserver.c

  Line 63 in 2ac1a61

  mcmap->map = msLoadMap(src->mapfile,NULL);

• mapcache/lib/source_mapserver.c

  Line 232 in 2ac1a61

  map = msLoadMap(src->mapfile, NULL);

My guess is that the new parameter could just take a NULL when called from Mapcache. If I can get a confirmation on this assumption, I'm glad to open a pull request.

[sdlime]

So this is for the experimental MapServer integration. I've never used that feature myself but assuming the mapfile being processed is configured in the mapcache config file and not via a request then you're correct. @tbonfort or @jbo-ads, is that assumption is correct?

--Steve

[jmckenna]

@mamaar your plan sounds good to me. If you can test your change locally, confirm it works with null, and then open a pull request with that change, soon-ish, we can include it in the upcoming MapCache release. thanks!

[jmckenna]

@mamaar @sdlime, all: I actually just hit this when upgrading the MapCache CI tests to use MapServer 8, with MapCache (in ubuntugis-unstable), and had to make this change for the build to pass. (see full PR). Let me know if all looks ok (will potentially include this in a 1.14.2 release at the end of this month). Even though MapServer as source for MapCache is still marked as experimental, some may be using it. Thanks.