Gmoccapy offset page - buttons

[hansu]

Just pull this out of #3494.

[@Sigma1912]

I have also prepared adding a buttonbox to the offsetpage:

Maybe we could move some of the 'edit offsets', 'Zero G92' , 'Set selected offset' buttons to the new button box. What do you think?

[hansu]

Maybe we could move some of the 'edit offsets', 'Zero G92' , 'Set selected offset' buttons to the new button box. What do you think?

Either that, or:

Or even better:

It only becomes interesting when having a lot of axes:

[Sigma1912]

I've moved away from trying to add more buttons to the bottom row. I think it's preferable to have the buttons that directly relate to editing values in the table inside the table frame, just like in the tool editor #3509.

Accordingly I would suggest to move the 'calculator' and 'zero g92' to the table frame and hide those until the 'edit offset' button is activated

[hansu]

I've moved away from trying to add more buttons to the bottom row. I think it's preferable to have the buttons that directly relate to editing values in the table inside the table frame, just like in the tool editor #3509.

Fine for me, but some users have hardware buttons beside the screen for the lower and right button box...

Accordingly I would suggest to move the 'calculator' and 'zero g92' to the table frame and hide those until the 'edit offset' button is activated

But "zero g92" should be also clickable when not in edit mode.

[Sigma1912]

Fine for me, but some users have hardware buttons beside the screen for the lower and right button box...

I know, that was the original layout but we've always had buttons in the preview window that are not aligned with that design so we have never really been consistent in that respect.
But you are right it may be worth to rethink the whole idea a bit.

For the use of Gmoccapy w/o touch screen an aligned hardware button doesn't really make life much easier if the assigned function requires mouse movement. I might as well call that function with the mouse in the first place.
So, say I have aligned hardware buttons, a mouse and a keyboard. Would I really want to use

1. the hardware button to activate the 'edit offsets' function
2. the mouse to select a cell in the offset table
3. the keyboard to enter a value
4. the hardware button to deactivate the 'edit offsets' function

So in that sense we could move the 'edit offsets', 'Set selected offset' and 'use calculator' buttons to the table frame without making gui operation in any way less convenient for users with aligned hardware buttons. For everybody else it really doesn't matter anyway as long as the grouping of the buttons still makes some logical sense.

But "zero g92" should be also clickable when not in edit mode.

Yes, I agree and it should remain in the bottom row of buttons. Although we may want to make it clearer that this also zeros G52 as these two offsets share the same values.

[hansu]

Yes Gmoccapy needs a mouse or a touch-screen. But maybe users prefer the haptics of the hardware buttons for the most used functions.
I thought only it is worth considering that the hardware buttons can be used if they fit the space and if it makes sense.

[hansu]

I could imagine something like this:

But I would move this to the end of the priority list...

[Sigma1912]

I like it. Would also follow the new toolpage layout.
If you want I could prepare a PR for this.