[Bug?] Scriptlets required fields are not validated upon upload

[olw-medcom]

Hey there,

I'm experiencing some strange behaviour with Scriptlets as of late.

This issue currently is that I have this scriptlet with these parameters:

<?xml version="1.0" encoding="UTF-8"?>
<scriptlet id="CommonEDSSBDHAsserts" xmlns="http://www.gitb.com/tdl/v1/">
    <params>
        <var name="providedEDSAuditEvent" type="string" />
        <var name="subtypeCode" type="string"/>
        <var name="matchingSBDH" type="string"/>
        <var name="deviceType" type="string"/>
        <var name="skipStepsRelatedToPatientDeliveryStatus" type="boolean"/>
        <var name="skipStepsRelatedToSBDHAckOrSBDHFhirAck" type="boolean"/>
    </params>

And here I call it:

        <call path="Scriptlets/Common-EDS-SBDH-Asserts.xml" from="ehmi-shared-suite">
            <input name="providedEDSAuditEvent">$userData{providedEDSAuditEvent}</input>
            <input name="deviceType">"AP"</input>
            <input name="subtypeCode">"msg-received"</input>
            <input name="matchingSBDH">$userData{userProvidedSBDH}</input>
            <input name="isPatientDeliveryStatus">"false"</input>
            <input name="isSBDHAckOrSBDHFhirAck">"false"</input>
        </call>

As you can see my required params skipStepsRelatedToPatientDeliveryStatus and skipStepsRelatedToSBDHAckOrSBDHFhirAck is not set, however when I upload the testcase in a testsuite everything works?

On another note, I experienced an issue where I had a shared suite that had previously been working, and then suddenly could not be linked to other specifications anymore. I was looking through logs etc and I could not figure out why. I even try deleting everything from the suite and a bunch of other things as well, but the only that that solved it was changing it's id so that it became a new specification.. Nothing else changed and it just worked again?

[costas80]

Hi @olw-medcom.

As you can see my required params skipStepsRelatedToPatientDeliveryStatus and skipStepsRelatedToSBDHAckOrSBDHFhirAck is not set, however when I upload the testcase in a testsuite everything works?

After checking this in depth I see that the reason you don't get the validation blocking you is because this is a scriptlet from another test suite. It is very complicated to do cross-test suite validations at test suite load time. Besides needing to load remote test suites in the validation flow, you could also have cases where the other test suite is not yet uploaded or changes after its initial upload.

The validation tries to catch as much as possible but needs to draw the line at some point. Also, as I noted above, things are never going to be perfect because you may end up changing referenced test suites after their initial upload. The best we can do is to include a message in the validation report to make you aware of this. In fact the validation report already includes a message as follows:

[TDL-088] Calls are made to scriptlet [scriptlets/uuid2.xml] from test suite [shared]. Ensure this will be available at runtime.

We could potentially adapt this to mention to ensure to include also its expected parameters (although I doubt that would make much of a difference). What do you think?

On another note, I experienced an issue where I had a shared suite that had previously been working, and then suddenly could not be linked to other specifications anymore.

We haven't had similar reports to this and based on what you share it's difficult to investigate and try to reproduce. If you see anything like this come up again I'd suggest you raise an issue so that we can check it further.