Skip to content

Commit fd5f968

Browse files
committed
adjust CORS headers and enhance Docker image naming with source hash
1 parent ebda09a commit fd5f968

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

src/controllers/cdnController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export const proxyReportsFile = async (req, res, filePath) => {
9999
if (!res.headersSent) {
100100
res.statusCode = 500;
101101
res.end(JSON.stringify({
102-
error: 'Failed to retrieve file',
102+
error: 'Server failed to respond',
103103
details: error.message
104104
}));
105105
}

src/index.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const getController = async (name) => {
5353
// Helper function to set CORS headers
5454
const setCORSHeaders = (res) => {
5555
res.setHeader('Access-Control-Allow-Origin', '*');
56-
res.setHeader('Access-Control-Allow-Methods', 'GET, POST, OPTIONS');
56+
res.setHeader('Access-Control-Allow-Methods', 'GET, OPTIONS');
5757
res.setHeader('Access-Control-Allow-Headers', 'Content-Type, Timing-Allow-Origin');
5858
res.setHeader('Access-Control-Max-Age', '86400');
5959
};
@@ -99,14 +99,6 @@ const handleRequest = async (req, res) => {
9999
return;
100100
}
101101

102-
// Validate URL to skip XSS attacks
103-
const unsafe = /onerror|onload|javascript:/i;
104-
if (unsafe.test(req.url)) {
105-
res.statusCode = 400
106-
res.end(JSON.stringify({ error: 'Invalid input' }));
107-
return;
108-
}
109-
110102
// Parse URL path
111103
const pathname = req.path;
112104

terraform/modules/run-service/main.tf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,14 @@ data "external" "source_hash" {
2525

2626
# Build Docker image
2727
resource "docker_image" "function_image" {
28-
name = "${var.region}-docker.pkg.dev/${var.project}/report-api/${var.service_name}"
28+
# hash added to image tag to force rebuilds ans service image updates when source changes
29+
name = "${var.region}-docker.pkg.dev/${var.project}/report-api/${var.service_name}:${data.external.source_hash.result.hash}"
2930

3031
build {
3132
context = var.source_directory
3233
dockerfile = "Dockerfile"
3334
platform = "linux/amd64"
3435
}
35-
triggers = {
36-
source_hash = data.external.source_hash.result.hash
37-
}
3836
}
3937

4038
resource "docker_registry_image" "registry_image" {

0 commit comments

Comments
 (0)