Issue #9 - Signal handlers are now disconnected in do_deactivate().

Author: Micah Carrick

README.markdown

@@ -61,28 +61,6 @@ Screenshots
 ![Python code in Source Code Browser](http://www.micahcarrick.com/images/gedit-source-code-browser/python.png)
 
 
-Changes
--------
-
-**Vesion 3.0.3**
-
-* Issue #7 - Replaced g_file_get_uri() with g_file_get_parse_name() for unicode 
-  support in calls to ctags.
-
-**Vesion 3.0.2**
-
-* Checks if image exists before trying to instantiate GdkPixbuf
-* Added the option to sort the list alphabetically or allow it to remain in the 
-  same order in which it appears in the source document.
-* Fixed expanding rows between documents by using the row mapping function
-
-**Vesion 3.0.1**
-
-* Added a configuration dialog.
-* Fixed bug where ctags fails to parse filenames with spaces.
-* Fixed bug with unpacking the "signature" field in C code.
-* Added icons for enumerators and typedefs in C code.
-
 Known Issues
 ------------
 

sourcecodebrowser/plugin.py

@@ -329,24 +329,32 @@ def do_activate(self):
         self._sourcetree.show_line_numbers = self.show_line_numbers
         self._sourcetree.expand_rows = self.expand_rows
         self._sourcetree.sort_list = self.sort_list
-
         panel = self.window.get_side_panel()
         panel.add_item(self._sourcetree, "SymbolBrowserPlugin", "Source Code", self.icon)
-        self._sourcetree.connect("focus", self.on_sourcetree_focus)
-        
+        self._handlers = []
+        hid = self._sourcetree.connect("focus", self.on_sourcetree_focus)
+        self._handlers.append((self._sourcetree, hid))
         if self.ctags_version is not None:
-            self._sourcetree.connect('tag-activated', self.on_tag_activated)
-            self.window.connect("active-tab-state-changed", self.on_tab_state_changed)
-            self.window.connect("active-tab-changed", self.on_active_tab_changed)
-            self.window.connect("tab-removed", self.on_tab_removed)
+            hid = self._sourcetree.connect('tag-activated', self.on_tag_activated)
+            self._handlers.append((self._sourcetree, hid))
+            hid = self.window.connect("active-tab-state-changed", self.on_tab_state_changed)
+            self._handlers.append((self.window, hid))
+            hid = self.window.connect("active-tab-changed", self.on_active_tab_changed)
+            self._handlers.append((self.window, hid))
+            hid = self.window.connect("tab-removed", self.on_tab_removed)
+            self._handlers.append((self.window, hid))
         else:
             self._sourcetree.set_sensitive(False)
 
     def do_deactivate(self):
         """ Deactivate the plugin """
         self._log.debug("Deactivating plugin")
+        for obj, hid in self._handlers:
+            obj.disconnect(hid)
+        self._handlers = None
         pane = self.window.get_side_panel()
         pane.remove_item(self._sourcetree)
+        self._sourcetree = None
 
     def _has_settings_schema(self):
         schemas = Gio.Settings.list_schemas()