[question] linq_aggregate API to avoid boxing?

[dodikk]

Are you planning to add linq_aggregate API for primitive types?

    NSNumber* totalCount = [shoppingCart linq_aggregate: ^NSNumber*(id<MyCommodity> item, NSNumber* aggregate)
    {
        NSNumber* orderedItemsCount = [item numberOfOrders];
        NSUInteger newResult = [orderedItemsCount unsignedIntegerValue] + [aggregate unsignedIntegerValue];

        return @(newResult);
    }];

In this example there is a lot of boxing/unboxing (NSNumber ==> NSUInteger ==> NSNumber) which is a good thing to avoid.

P.S. I know that integers can be "safely" casted to id. But I strongly dislike this approach. Moreover, it does not work for [NSNumber floatValue].

[dodikk]

Note : the code example above crashes since aggregate has an unexpected type.

        if (aggregate == nil) {
            aggregate = item;
        }

Why are you checking this condition and assigning a wrong object?
If linq_aggregate is supposed to produce an object or the same type as array elements, please document it explicitly.

@ColinEberhardt what do you think about such use case?

[dodikk]

NSArray* names = @[@"bill", @"bob", @"brian"];

id aggregate = [names linq_aggregate:^id(id item, id aggregate) {
    return [NSString stringWithFormat:@"%@, %@", aggregate, item];
}];

Eventually, the fix will break the code in the readme and the user will have to handle aggregate == nil situation properly. Still, It's a fair trade-off for the library's flexibility.

[dodikk]

@ColinEberhardt I've removed the mentioned check in a patch #13

Please let me know if you find a better approach for my use case.