Add closures feature flag and enablement checks

Introduces a new 'closures' feature flag to the compiler, updates feature enumeration, and adds checks to ensure closures are only used when the feature is enabled. Test configurations are updated to enable the closures feature for relevant tests.

Author: BlobMaster41

src/common.ts

@@ -191,6 +191,7 @@ export namespace CommonNames {
   export const ASC_FEATURE_RELAXED_SIMD = "ASC_FEATURE_RELAXED_SIMD";
   export const ASC_FEATURE_EXTENDED_CONST = "ASC_FEATURE_EXTENDED_CONST";
   export const ASC_FEATURE_STRINGREF = "ASC_FEATURE_STRINGREF";
+  export const ASC_FEATURE_CLOSURES = "ASC_FEATURE_CLOSURES";
   export const ASC_VERSION_MAJOR = "ASC_VERSION_MAJOR";
   export const ASC_VERSION_MINOR = "ASC_VERSION_MINOR";
   export const ASC_VERSION_PATCH = "ASC_VERSION_PATCH";

src/compiler.ts

@@ -7497,6 +7497,14 @@ export class Compiler extends DiagnosticEmitter {
       // Analyze captured variables before compiling
       let captures = this.analyzeCapturedVariables(declaration, flow);
       if (captures.size > 0) {
+        // Check if closures feature is enabled
+        if (!this.options.hasFeature(Feature.Closures)) {
+          this.error(
+            DiagnosticCode.Feature_0_is_not_enabled,
+            expression.range, "closures"
+          );
+          return module.unreachable();
+        }
         instance.capturedLocals = captures;
         instance.outerFunction = sourceFunction;
         this.ensureClosureEnvironment(sourceFunction, captures, flow);
@@ -7515,6 +7523,14 @@ export class Compiler extends DiagnosticEmitter {
       // Analyze captured variables before compiling
       let captures = this.analyzeCapturedVariables(declaration, flow);
       if (captures.size > 0) {
+        // Check if closures feature is enabled
+        if (!this.options.hasFeature(Feature.Closures)) {
+          this.error(
+            DiagnosticCode.Feature_0_is_not_enabled,
+            expression.range, "closures"
+          );
+          return module.unreachable();
+        }
         instance.capturedLocals = captures;
         instance.outerFunction = sourceFunction;
         this.ensureClosureEnvironment(sourceFunction, captures, flow);
@@ -7990,6 +8006,14 @@ export class Compiler extends DiagnosticEmitter {
         let declaration = funcExpr.declaration;
         let capturedNames = this.analyzeCapturedVariablesWithDeclared(declaration, flow, instance, declaredVars);
         if (capturedNames.size > 0) {
+          // Check if closures feature is enabled
+          if (!this.options.hasFeature(Feature.Closures)) {
+            this.error(
+              DiagnosticCode.Feature_0_is_not_enabled,
+              funcExpr.range, "closures"
+            );
+            break;
+          }
           // Store captured names for later use when compiling variable declarations
           let existingNames = instance.preCapturedNames;
           if (!existingNames) {

src/index-wasm.ts

@@ -202,6 +202,8 @@ export const FEATURE_RELAXED_SIMD = Feature.RelaxedSimd;
 export const FEATURE_EXTENDED_CONST = Feature.ExtendedConst;
 /** String references. */
 export const FEATURE_STRINGREF = Feature.Stringref;
+/** Closures. */
+export const FEATURE_CLOSURES = Feature.Closures;
 /** All features. */
 export const FEATURES_ALL = Feature.All;
 /** Default features. */

src/program.ts

@@ -1086,6 +1086,8 @@ export class Program extends DiagnosticEmitter {
       i64_new(options.hasFeature(Feature.ExtendedConst) ? 1 : 0, 0));
     this.registerConstantInteger(CommonNames.ASC_FEATURE_STRINGREF, Type.bool,
       i64_new(options.hasFeature(Feature.Stringref) ? 1 : 0, 0));
+    this.registerConstantInteger(CommonNames.ASC_FEATURE_CLOSURES, Type.bool,
+      i64_new(options.hasFeature(Feature.Closures) ? 1 : 0, 0));
 
     // remember deferred elements
     let queuedImports = new Array<QueuedImport>();

std/assembly/shared/feature.ts

@@ -34,8 +34,10 @@ export const enum Feature {
   ExtendedConst = 1 << 13, // see: https://github.com/WebAssembly/extended-const
   /** Reference typed strings. */
   Stringref = 1 << 14, // see: https://github.com/WebAssembly/stringref
+  /** Closures. */
+  Closures = 1 << 15,
   /** All features. */
-  All = (1 << 15) - 1
+  All = (1 << 16) - 1
 }
 
 /** Gets the name of the specified feature one would specify on the command line. */
@@ -56,6 +58,7 @@ export function featureToString(feature: Feature): string {
     case Feature.RelaxedSimd: return "relaxed-simd";
     case Feature.ExtendedConst: return "extended-const";
     case Feature.Stringref: return "stringref";
+    case Feature.Closures: return "closures";
   }
   assert(false);
   return "";

tests/compiler/closure-class.json

@@ -1,3 +1,5 @@
 {
-  "asc_flags": []
+  "asc_flags": [
+    "--enable", "closures"
+  ]
 }

tests/compiler/closure-stress.json

@@ -1,4 +1,5 @@
 {
   "asc_flags": [
+    "--enable", "closures"
   ]
 }

tests/compiler/closure.json

@@ -1,4 +1,5 @@
 {
   "asc_flags": [
+    "--enable", "closures"
   ]
 }