Skip to content

[BUG] Indentation left does not work any more in latest version #171

@android-outliner

Description

@android-outliner

If you press the indentation right button, everything is ok.
Indentation left does intent to the right instead of indent to the left.

In the latest RT-Editor Demo App the issue can be simply reproduced.

The reason seems to be this code in HorizontalRTToolbar.java (line 646):

        else if (id == R.id.toolbar_inc_indent) {
            mListener.onEffectSelected(Effects.INDENTATION, Helper.getLeadingMarging());
        }

        else if (id == R.id.toolbar_dec_indent) {
            mListener.onEffectSelected(Effects.INDENTATION, Helper.getLeadingMarging());     //**** minus missing ****
        }

For R.id.toolbar_dec_indent a minus is missing: -Helper.getLeadingMarging()

It worked in an older version. The error seems to be introduced when migrating to AndroidX.
This is the problematic commit:
6982075

Unfortunately I can't stick to any older version because the Google Play Store complains the old version of org.greenrobot:eventbus:3.1.1 inside the RTEditor library when uploading my App.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions